From 94624f07af196da681655b38be6acc3b0c014923 Mon Sep 17 00:00:00 2001 From: Jackson Coxson Date: Tue, 21 Oct 2025 09:16:47 -0600 Subject: [PATCH] Rename screenshot_clear to screenshot_take_screenshot in FFI --- cpp/examples/screenshot.cpp | 2 +- cpp/include/idevice++/dvt/screenshot.hpp | 2 +- cpp/src/dvt/screenshot.cpp | 4 ++-- ffi/src/dvt/screenshot.rs | 2 +- 4 files changed, 5 insertions(+), 5 deletions(-) diff --git a/cpp/examples/screenshot.cpp b/cpp/examples/screenshot.cpp index dc48e9f..8c76abc 100644 --- a/cpp/examples/screenshot.cpp +++ b/cpp/examples/screenshot.cpp @@ -88,7 +88,7 @@ int main(int argc, char** argv) { [](FfiError e) -> ScreenshotClient { die("failed to create ScreenshotClient", e); }); // 9) Capture screenshot - auto buf = ss.capture().unwrap_or_else( + auto buf = ss.take_screenshot().unwrap_or_else( [](FfiError e) -> std::vector { die("failed to capture screenshot", e); }); // 10) Write PNG file diff --git a/cpp/include/idevice++/dvt/screenshot.hpp b/cpp/include/idevice++/dvt/screenshot.hpp index 7e38fd9..9f10225 100644 --- a/cpp/include/idevice++/dvt/screenshot.hpp +++ b/cpp/include/idevice++/dvt/screenshot.hpp @@ -28,7 +28,7 @@ class ScreenshotClient { /// Captures a screenshot and returns it as a PNG buffer. /// /// On success, returns a vector containing PNG-encoded bytes. - Result, FfiError> capture(); + Result, FfiError> take_screenshot(); ~ScreenshotClient() noexcept = default; ScreenshotClient(ScreenshotClient&&) noexcept = default; diff --git a/cpp/src/dvt/screenshot.cpp b/cpp/src/dvt/screenshot.cpp index fae32c9..e823d41 100644 --- a/cpp/src/dvt/screenshot.cpp +++ b/cpp/src/dvt/screenshot.cpp @@ -13,11 +13,11 @@ Result ScreenshotClient::create(RemoteServer& server return Ok(ScreenshotClient::adopt(out)); } -Result, FfiError> ScreenshotClient::capture() { +Result, FfiError> ScreenshotClient::take_screenshot() { uint8_t* data = nullptr; size_t len = 0; - FfiError e(::screenshot_client_clear(handle_.get(), &data, &len)); + FfiError e(::screenshot_client_take_screenshot(handle_.get(), &data, &len)); if (e) { return Err(e); } diff --git a/ffi/src/dvt/screenshot.rs b/ffi/src/dvt/screenshot.rs index bfe9153..6c3848a 100644 --- a/ffi/src/dvt/screenshot.rs +++ b/ffi/src/dvt/screenshot.rs @@ -86,7 +86,7 @@ pub unsafe extern "C" fn screenshot_client_free(handle: *mut ScreenshotClientHan /// - `data` and `len` must be valid writable pointers. /// - The data returned through `*data` must be freed by the caller with `idevice_data_free`. #[unsafe(no_mangle)] -pub unsafe extern "C" fn screenshot_client_clear( +pub unsafe extern "C" fn screenshot_client_take_screenshot( handle: *mut ScreenshotClientHandle<'static>, data: *mut *mut u8, len: *mut usize,