Log if h4 type is unknown

idevice/src/services/bt_packet_logger.rs

@@ -5,7 +5,7 @@
 use std::pin::Pin;
 
 use futures::Stream;
-use log::{debug, warn};
+use log::warn;
 
 use crate::{Idevice, IdeviceError, IdeviceService, obf};
 
@@ -148,13 +148,6 @@ impl BtPacketLoggerClient {
                 let kind = BtPacketKind::from_byte(frame[off]);
                 let payload = &frame[off + 1..];
 
-                // soft advisory check
-                let advisory = hdr.length as usize;
-                let actual = 1 + payload.len();
-                if advisory != actual {
-                    debug!("BTPacketLogger advisory length {} != actual {}", advisory, actual);
-                }
-
                 // make H4 buffer
                 let mut h4 = Vec::with_capacity(1 + payload.len());
                 if let Some(t) = kind.h4_type() {

tools/src/pcap.rs

@@ -1,4 +1,5 @@
 use idevice::bt_packet_logger::BtPacketKind;
+use log::warn;
 use tokio::io::{AsyncWrite, AsyncWriteExt};
 
 // Classic PCAP (big-endian) global header for DLT_BLUETOOTH_HCI_H4_WITH_PHDR (201)
@@ -40,6 +41,7 @@ pub async fn write_pcap_record<W: AsyncWrite + Unpin>(
 ) -> std::io::Result<()> {
     // Prepend 4-byte direction flag to the packet body
     let Some(dir) = dir_flag(kind) else {
+        warn!("Unknown H4 packet type: {kind:?}");
         return Ok(());
     };
     let cap_len = 4u32 + h4_payload.len() as u32;